[
https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501376#comment-14501376
]
ASF GitHub Bot commented on FLINK-1523:
---------------------------------------
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-94167112
Hi @andralungu! Thanks for the update :-)
I left a few inline comments. Overall it looks good, I just had a little
trouble following the logic in `VertexCentricIteration` with your changes. I
think it could be simplified a bit, so that all configuration options are set
in one place. Other that that, there are some javadocs missing, please make
sure to add a description on every public method.
One concern I have is whether the `Vertex` class is the right place for the
degrees fields and methods. These should be available only inside the iteration
methods. In the current implementation one can use the public `setInDegree`
method and then retrieve the value, regardless of whether that happens inside
an iteration or whether it was set in the configuration. Could we instead
create methods inside the `VertexUpdateFunction` and `MessagingFunction`?
Something like `getVertexInDegree()` instead of `vertex.getInDegree()`? Or do
you have a better idea?
> Vertex-centric iteration extensions
> -----------------------------------
>
> Key: FLINK-1523
> URL: https://issues.apache.org/jira/browse/FLINK-1523
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Andra Lungu
>
> We would like to make the following extensions to the vertex-centric
> iterations of Gelly:
> - allow vertices to access their in/out degrees and the total number of
> vertices of the graph, inside the iteration.
> - allow choosing the neighborhood type (in/out/all) over which to run the
> vertex-centric iteration. Now, the model uses the updates of the in-neighbors
> to calculate state and send messages to out-neighbors. We could add a
> parameter with value "in/out/all" to the {{VertexUpdateFunction}} and
> {{MessagingFunction}}, that would indicate the type of neighborhood.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
