[
https://issues.apache.org/jira/browse/FLINK-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513707#comment-14513707
]
ASF GitHub Bot commented on FLINK-1523:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-96558324
Looks good in general. A few thoughts on this:
Your prior discussion involved efficiency, and Vasia suggested to not carry
the degrees in all cases (as they are not needed in most cases). It seems that
was not yet realized, because the Vertex class always carries the degrees.
I think we can improve the abstraction between the with-degree and
without-degree case a bit. Cases where one has to throw a "not supported" can
usually be improved with a good inheritance hierarchy. Does it work to make the
VertexWithDegrees class a subclass of the Vertex class?
Also, as a bit of background: Vertex is a subclass of "Tuple2". Tuples are
currently the fastest data types in Flink. By adding additional Fields to the
Tuple, you are making it a POJO (as far as I know), which is a bit slower to
serialize type.
Also: primitives are usually better than boxed types. Prefer `long` over
`Long` where possible.
> Vertex-centric iteration extensions
> -----------------------------------
>
> Key: FLINK-1523
> URL: https://issues.apache.org/jira/browse/FLINK-1523
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Reporter: Vasia Kalavri
> Assignee: Andra Lungu
>
> We would like to make the following extensions to the vertex-centric
> iterations of Gelly:
> - allow vertices to access their in/out degrees and the total number of
> vertices of the graph, inside the iteration.
> - allow choosing the neighborhood type (in/out/all) over which to run the
> vertex-centric iteration. Now, the model uses the updates of the in-neighbors
> to calculate state and send messages to out-neighbors. We could add a
> parameter with value "in/out/all" to the {{VertexUpdateFunction}} and
> {{MessagingFunction}}, that would indicate the type of neighborhood.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
