Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/622#discussion_r29140453
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -345,26 +346,9 @@ public void onComplete(Throwable failure, Object
success) throws Throwable {
}
}
else {
- if (success == null) {
- markFailed(new
Exception("Failed to deploy the task to slot " + slot + ": TaskOperationResult
was null"));
- }
-
- if (success instanceof
TaskOperationResult) {
- TaskOperationResult
result = (TaskOperationResult) success;
-
- if
(!result.executionID().equals(attemptId)) {
- markFailed(new
Exception("Answer execution id does not match the request execution id."));
- } else if
(result.success()) {
-
switchToRunning();
- } else {
- // deployment
failed :(
- markFailed(new
Exception("Failed to deploy the task " +
-
getVertexWithAttempt() + " to slot " + slot + ": " + result
-
.description()));
- }
- } else {
+ if (!(success instanceof
Messages.Acknowledge$)) {
--- End diff --
I think this line is not parsable in Eclipse (the $ mess with the Java
parser).
A workaround is to expose the case object class and object via a utility
method and check against that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
