Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/622#discussion_r29140570
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
    @@ -137,7 +137,7 @@ extends Actor with ActorLogMessages with ActorLogging {
       protected val resources = 
HardwareDescription.extractFromSystem(memoryManager.getMemorySize)
     
       /** Registry of all tasks currently executed by this TaskManager */
    -  protected val runningTasks = 
scala.collection.mutable.HashMap[ExecutionAttemptID, Task]()
    +  protected val runningTasks = 
scala.collection.concurrent.TrieMap[ExecutionAttemptID, Task]()
    --- End diff --
    
    I have recently read (I think in the Databricks Scala guide) that they 
discourage the Scala concurrent package, because of bugs. How about using the 
java concurrent HashMap? That one has pretty good performance seems to work 
reliably.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to