[
https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976517#comment-15976517
]
ASF GitHub Bot commented on FLINK-6130:
---------------------------------------
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/3726
@tillrohrmann That is right. We can close this PR surely. BTW, Should we
make another jira refactoring this class and
```AbstractYarnFlinkApplicationMasterRunner ``` ? Because I watch the
```AbstractYarnFlinkApplicationMasterRunner ``` and find only one subclass. If
we do create another jira, You are the reporter and assign it to me. How do you
think of this ?
> Consider calling resourceManager#getTerminationFuture() with lock held
> ----------------------------------------------------------------------
>
> Key: FLINK-6130
> URL: https://issues.apache.org/jira/browse/FLINK-6130
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> In YarnFlinkApplicationMasterRunner#runApplicationMaster() :
> {code}
> synchronized (lock) {
> LOG.info("Starting High Availability Services");
> ...
> }
> // wait for resource manager to finish
> resourceManager.getTerminationFuture().get();
> {code}
> resourceManager#getTerminationFuture() is called without holding lock.
> We should store the value returned from
> resourceManager#getTerminationFuture() inside the synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
