[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972731#comment-15972731 ]
Chesnay Schepler commented on FLINK-6130: ----------------------------------------- [~mingleizhang] No, it is of type Future<Void>, meaning it always returns null. If get() returns (without exception) it means the ResourceManager has shut down, as that is the definition of the termination future, see RpcEndpoint#getTerminationFuture. > Consider calling resourceManager#getTerminationFuture() with lock held > ---------------------------------------------------------------------- > > Key: FLINK-6130 > URL: https://issues.apache.org/jira/browse/FLINK-6130 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Assignee: mingleizhang > Priority: Minor > > In YarnFlinkApplicationMasterRunner#runApplicationMaster() : > {code} > synchronized (lock) { > LOG.info("Starting High Availability Services"); > ... > } > // wait for resource manager to finish > resourceManager.getTerminationFuture().get(); > {code} > resourceManager#getTerminationFuture() is called without holding lock. > We should store the value returned from > resourceManager#getTerminationFuture() inside the synchronized block. -- This message was sent by Atlassian JIRA (v6.3.15#6346)