Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3743#discussion_r112564205
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/call.scala
---
@@ -49,6 +57,128 @@ case class Call(functionName: String, args:
Seq[Expression]) extends Expression
}
/**
+ * Over expression for calcite over transform.
+ *
+ * @param agg over-agg expression
+ * @param aggAlias agg alias for following `select()` clause.
+ * @param overWindowAlias over window alias
+ * @param overWindow over window
+ */
+case class OverCall(
--- End diff --
We also need to validate other properties of the overWindow:
- check that the partitionBy expressions are valid fields in the input.
- If a partitionBy expression is not a field, we would need to push the
expression into a Project before the Project with the overWindow and reference
the new field. This would need to happen in `Table.window()`. I think for now
we can have the restriction that only field references are allowed expressions.
- validate the `preceding` and `following` are literals @
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
