Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3733#discussion_r113050568
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedRowsOver.scala
 ---
    @@ -48,15 +49,15 @@ class ProcTimeBoundedRowsOver(
         genAggregations: GeneratedAggregationsFunction,
         precedingOffset: Long,
         aggregatesTypeInfo: RowTypeInfo,
    -    inputType: TypeInformation[Row])
    -  extends ProcessFunction[Row, Row]
    +    inputType: TypeInformation[CRow])
    +  extends ProcessFunction[CRow, CRow]
         with Compiler[GeneratedAggregations] {
     
       Preconditions.checkArgument(precedingOffset > 0)
     
       private var accumulatorState: ValueState[Row] = _
    -  private var rowMapState: MapState[Long, JList[Row]] = _
    -  private var output: Row = _
    +  private var rowMapState: MapState[Long, JList[CRow]] = _
    --- End diff --
    
    Same as for the other over window. Let's use `Row` for the state and 
extract the `Row` from the `CRow`.
    `output` should be a `CRow`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to