[ 
https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982040#comment-15982040
 ] 

ASF GitHub Bot commented on FLINK-6361:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3762#discussion_r113073730
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRangeProcessFunctionTest.scala
 ---
    @@ -51,7 +51,7 @@ class BoundedProcessingOverRangeProcessFunctionTest {
     
         val aggregates =
           Array(new LongMinWithRetractAggFunction,
    -            new 
LongMaxWithRetractAggFunction).asInstanceOf[Array[AggregateFunction[_]]]
    +            new 
LongMaxWithRetractAggFunction).asInstanceOf[Array[AggregateFunction[_,_]]]
    --- End diff --
    
    +space


> Finalize the AggregateFunction interface and refactoring built-in aggregates
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-6361
>                 URL: https://issues.apache.org/jira/browse/FLINK-6361
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> We have completed codeGen for all aggregate runtime functions. Now we can 
> finalize the AggregateFunction. This includes 1) remove Accumulator trait; 2) 
> remove accumulate, retract, merge, resetAccumulator, getAccumulatorType 
> methods from interface, and allow them as contracted methods for UDAGG; 3) 
> refactoring the built-in aggregates accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to