[
https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982037#comment-15982037
]
ASF GitHub Bot commented on FLINK-6361:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3762#discussion_r113066365
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/AggregateFunction.scala
---
@@ -17,36 +17,93 @@
*/
package org.apache.flink.table.functions
-import java.util.{List => JList}
-
-import org.apache.flink.api.common.typeinfo.TypeInformation
-import org.apache.flink.table.api.TableException
-
/**
* Base class for User-Defined Aggregates.
*
- * @tparam T the type of the aggregation result
+ * The behavior of an [[AggregateFunction]] can be defined by
implementing a series of custom
+ * methods. An [[AggregateFunction]] needs at least three methods:
createAccumulator, getValue,
--- End diff --
make this a list. Scala style supports markdown syntax:
```
... needs at least three methods:
- createAccumulator,
- accumulate, and
- getValue.
There are a few other methods that can be optional to have:
- retract,
- merge,
- resetAccumulator, and
- getAccumulatorType.
```
> Finalize the AggregateFunction interface and refactoring built-in aggregates
> ----------------------------------------------------------------------------
>
> Key: FLINK-6361
> URL: https://issues.apache.org/jira/browse/FLINK-6361
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> We have completed codeGen for all aggregate runtime functions. Now we can
> finalize the AggregateFunction. This includes 1) remove Accumulator trait; 2)
> remove accumulate, retract, merge, resetAccumulator, getAccumulatorType
> methods from interface, and allow them as contracted methods for UDAGG; 3)
> refactoring the built-in aggregates accordingly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
