[
https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985901#comment-15985901
]
ASF GitHub Bot commented on FLINK-6337:
---------------------------------------
GitHub user zhijiangW opened a pull request:
https://github.com/apache/flink/pull/3785
[FLINK-6337][network] Remove the buffer provider from
PartitionRequestServerHandler
Currently, `PartitionRequestServerHandler` will create a `LocalBufferPool`
when the channel is registered. The `LocalBufferPool` is only used to get
segment size for creating read view in `SpillableSubpartition`, and the buffers
in the pool will not be used all the time, so it will waste the buffer resource
of global pool.
We would like to remove the `LocalBufferPool` from the
`PartitionRequestServerHandler`, and the `LocalBufferPool` in `ResultPartition`
can also provide the segment size for creating sub partition view.
This modification will not effect the current behavior and will get
benefits of saving buffer resources.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhijiangW/flink FLINK-6337
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3785.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3785
----
commit 306f32414eabce5522ec2a8883aa27285e6aa3e4
Author: Zhijiang <wangzhijiang...@aliyun.com>
Date: 2017-04-26T08:18:54Z
[FLINK-6337][network] Remove the buffer provider from
PartitionRequestServerHandler
----
> Remove the buffer provider from PartitionRequestServerHandler
> -------------------------------------------------------------
>
> Key: FLINK-6337
> URL: https://issues.apache.org/jira/browse/FLINK-6337
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
>
> Currently, {{PartitionRequestServerHandler}} will create a
> {{LocalBufferPool}} when the channel is registered. The {{LocalBufferPool}}
> is only used to get segment size for creating read view in
> {{SpillableSubpartition}}, and the buffers in the pool will not be used all
> the time, so it will waste the buffer resource of global pool.
> We would like to remove the {{LocalBufferPool}} from the
> {{PartitionRequestServerHandler}}, and the {{LocalBufferPool}} in
> {{ResultPartition}} can also provide the segment size for creating sub
> partition view.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
