Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3522#discussion_r113657881
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
---
@@ -222,11 +227,40 @@ public CheckpointStreamFactory
createStreamFactory(JobID jobId,
@Override
public CheckpointStreamFactory createSavepointStreamFactory(
- JobID jobId,
String operatorIdentifier,
String targetLocation) throws IOException {
- return
checkpointStreamBackend.createSavepointStreamFactory(jobId, operatorIdentifier,
targetLocation);
+ return
checkpointStreamBackend.createSavepointStreamFactory(operatorIdentifier,
targetLocation);
+ }
+
+ @Override
+ public boolean supportsExternalizedMetadata() {
+ return checkpointStreamBackend.supportsExternalizedMetadata();
+ }
+
+ @Nullable
+ @Override
+ public String getMetadataPersistenceLocation() {
--- End diff --
The meta data location might be a concept that justifies introducing a
class. In particular, it seems that there might be different location concepts
in the future, so simply encoding all this in a string is questionable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
