Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3522#discussion_r113661393
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -213,6 +218,23 @@ public boolean discard(JobStatus jobStatus) throws
Exception {
void discard() throws Exception {
try {
+ // check if we have a shortcut hook to dispose the state
+ final StateDisposeHook disposeHook = this.disposeHook;
+ if (disposeHook != null) {
+ // fast path!
--- End diff --
This method is now a bit more lengthy than it could be; i would suggest to
factor out the two paths (fast and standard) in 2 private methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
