[
https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986325#comment-15986325
]
ASF GitHub Bot commented on FLINK-5823:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3522#discussion_r113662147
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoint.java
---
@@ -213,6 +218,23 @@ public boolean discard(JobStatus jobStatus) throws
Exception {
void discard() throws Exception {
try {
+ // check if we have a shortcut hook to dispose the state
+ final StateDisposeHook disposeHook = this.disposeHook;
+ if (disposeHook != null) {
+ // fast path!
--- End diff --
On a second look, do you think it could even make sense to have the
previous behaviour also encapsulated as a cleanup hook and get rid of the if
completely?
> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
> Key: FLINK-5823
> URL: https://issues.apache.org/jira/browse/FLINK-5823
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
