[
https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986294#comment-15986294
]
ASF GitHub Bot commented on FLINK-5823:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3522#discussion_r113657881
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
---
@@ -222,11 +227,40 @@ public CheckpointStreamFactory
createStreamFactory(JobID jobId,
@Override
public CheckpointStreamFactory createSavepointStreamFactory(
- JobID jobId,
String operatorIdentifier,
String targetLocation) throws IOException {
- return
checkpointStreamBackend.createSavepointStreamFactory(jobId, operatorIdentifier,
targetLocation);
+ return
checkpointStreamBackend.createSavepointStreamFactory(operatorIdentifier,
targetLocation);
+ }
+
+ @Override
+ public boolean supportsExternalizedMetadata() {
+ return checkpointStreamBackend.supportsExternalizedMetadata();
+ }
+
+ @Nullable
+ @Override
+ public String getMetadataPersistenceLocation() {
--- End diff --
The meta data location might be a concept that justifies introducing a
class. In particular, it seems that there might be different location concepts
in the future, so simply encoding all this in a string is questionable.
> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
> Key: FLINK-5823
> URL: https://issues.apache.org/jira/browse/FLINK-5823
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
