Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/3785#discussion_r113706078
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java
---
@@ -68,7 +68,6 @@ public void testSuccessfulProgramAfterFailure() {
try {
runKMeans(cluster.getLeaderRPCPort());
- fail("This program execution should have
failed.");
--- End diff --
This case will fail if not remove it.
I guess the buffer amount is not enough for this case before, because some
are shared by buffer provider in handler. After remove the buffer provider from
handler, the buffer is enough now. So the `runKmeans` can execute correctly,
not enter catch part or fail process.
I am not familiar with this case and not sure whether my understanding is
right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
