Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/3785#discussion_r113946358
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartitionTest.java
---
@@ -68,7 +68,11 @@ public static void shutdown() {
@Override
ResultSubpartition createSubpartition() {
- return new SpillableSubpartition(0,
mock(ResultPartition.class), ioManager);
+ ResultPartition parent = mock(ResultPartition.class);
--- End diff --
I guess you want to reuse this mocked `ResultPartition` in all the internal
tests, and I notice that there already exists `createSubpartition` override
method in this test, so I can modify the return type of `SpillableSubpartition`
instead. Do you think so?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
