[ 
https://issues.apache.org/jira/browse/FLINK-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989323#comment-15989323
 ] 

ASF GitHub Bot commented on FLINK-6414:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/3800

    [FLINK-6414] [build] Use scala.binary.version in place of 
change-scala-version.sh

    Use scala.binary.version as defined in the parent POM and remove the script 
to swap scala version identifiers.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 
6414_use_scala_binary_version_in_place_of_change_scala_version_sh

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3800.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3800
    
----
commit 6d0ca2f9ddf3d33f9f2953242234e5e053cb00b5
Author: Greg Hogan <[email protected]>
Date:   2017-04-27T18:43:18Z

    [FLINK-6414] [build] Use scala.binary.version in place of 
change-scala-version.sh
    
    Use scala.binary.version as defined in the parent POM and remove the
    script to swap scala version identifiers.

----


> Use scala.binary.version in place of change-scala-version.sh
> ------------------------------------------------------------
>
>                 Key: FLINK-6414
>                 URL: https://issues.apache.org/jira/browse/FLINK-6414
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> Recent commits have failed to modify {{change-scala-version.sh}} resulting in 
> broken builds for {{scala-2.11}}. It looks like we can remove the need for 
> this script by replacing hard-coded references to the Scala version with 
> Flink's maven variable {{scala.binary.version}}.
> I had initially realized that the change script is [only used for 
> building|https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/building.html#scala-versions]
>  and not for switching the IDE environment.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to