[
https://issues.apache.org/jira/browse/FLINK-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006045#comment-16006045
]
ASF GitHub Bot commented on FLINK-6414:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3800
@greghogan I think we should keep the `force-shading` approach to have
every project pass through the shade plugin, for various reasons. Resolving
variables (as required here) is one of them, but filtering of configuration
files, signature files, etc. are also very good reasons. Also, there may be
"single use" shaded dependencies in non-scala projects, which could still be
shaded on the fly in the using project directly (netty in flink-runtime would
be such a case).
> Use scala.binary.version in place of change-scala-version.sh
> ------------------------------------------------------------
>
> Key: FLINK-6414
> URL: https://issues.apache.org/jira/browse/FLINK-6414
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.3.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
>
> Recent commits have failed to modify {{change-scala-version.sh}} resulting in
> broken builds for {{scala-2.11}}. It looks like we can remove the need for
> this script by replacing hard-coded references to the Scala version with
> Flink's maven variable {{scala.binary.version}}.
> I had initially realized that the change script is [only used for
> building|https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/building.html#scala-versions]
> and not for switching the IDE environment.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
