[
https://issues.apache.org/jira/browse/FLINK-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989407#comment-15989407
]
ASF GitHub Bot commented on FLINK-6382:
---------------------------------------
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3779#discussion_r114009718
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java
---
@@ -41,17 +43,41 @@
@Rule
public ExpectedException expectedException = ExpectedException.none();
- protected DriverBaseITCase(TestExecutionMode mode) {
+ protected final String idType;
+
+ protected DriverBaseITCase(TestExecutionMode mode, String idType) {
super(mode);
+
+ this.idType = idType;
}
- // extend MultipleProgramsTestBase default to include object reuse mode
- @Parameterized.Parameters(name = "Execution mode = {0}")
+ @Parameterized.Parameters(name = "Execution mode = {0}, ID type = {1}")
public static Collection<Object[]> executionModes() {
- return Arrays.asList(
- new Object[] { TestExecutionMode.CLUSTER },
- new Object[] { TestExecutionMode.CLUSTER_OBJECT_REUSE },
- new Object[] { TestExecutionMode.COLLECTION });
+ List<Object[]> executionModes = new ArrayList<>();
+
+ for (TestExecutionMode executionMode :
TestExecutionMode.values()) {
+ for (String idType : new String[] {"byte",
"nativeByte", "short", "nativeShort", "char", "nativeChar",
+
"integer", "nativeInteger", "long", "nativeLong", "string", "nativeString"}) {
--- End diff --
What do you think if we declare the list of `idType` before the outer loop?
IMHO, this will make formation better.
> Support all numeric types for generated graphs in Gelly examples
> ----------------------------------------------------------------
>
> Key: FLINK-6382
> URL: https://issues.apache.org/jira/browse/FLINK-6382
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Affects Versions: 1.3.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Minor
> Fix For: 1.3.0
>
>
> The Gelly examples current support {{IntValue}}, {{LongValue}}, and
> {{StringValue}} for {{RMatGraph}}. Allow transformations and tests for all
> generated graphs for {{ByteValue}}, {{Byte}}, {{ShortValue}}, {{Short}},
> {{CharValue}}, {{Character}}, {{Integer}}, {{Long}}, and {{String}}.
> This is additionally of interest for benchmarking and testing modifications
> to Flink's internal sort.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
