[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993336#comment-15993336
]
ASF GitHub Bot commented on FLINK-6364:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114287252
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointTypeTest.java
---
@@ -36,7 +36,8 @@
*/
@Test
public void testOrdinalsAreConstant() {
- assertEquals(0, CheckpointType.FULL_CHECKPOINT.ordinal());
- assertEquals(1, CheckpointType.SAVEPOINT.ordinal());
+ assertEquals(0,
CheckpointType.INCREMENTAL_CHECKPOINT.ordinal());
+ assertEquals(1, CheckpointType.FULL_CHECKPOINT.ordinal());
+ assertEquals(2, CheckpointType.SAVEPOINT.ordinal());
--- End diff --
The purpose of this test is to ensures that encoding of checkpoint types
remains stable for compatibility of Flink savepoints, and this changes would
break the compatibility. In this sense, it should enforce "append-only" for new
chckpoint types. To fix this problem, `CheckpointType.INCREMENTAL_CHECKPOINT`
should be encoded as value 2 and the other types must be changed back to their
old value.
> Implement incremental checkpointing in RocksDBStateBackend
> ----------------------------------------------------------
>
> Key: FLINK-6364
> URL: https://issues.apache.org/jira/browse/FLINK-6364
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Xiaogang Shi
> Assignee: Xiaogang Shi
>
> {{RocksDBStateBackend}} is well suited for incremental checkpointing because
> RocksDB is base on LSM trees, which record updates in new sst files and all
> sst files are immutable. By only materializing those new sst files, we can
> significantly improve the performance of checkpointing.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
