[
https://issues.apache.org/jira/browse/FLINK-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994715#comment-15994715
]
ASF GitHub Bot commented on FLINK-6078:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3781
Good set of changes. I looked more deeply over the non-test code and the
Kafka test code. Both look good.
The remaining tests look like a pretty straightforward replacement of
`RemoteEnvironment` by `TestEnvironment` and integration of `HaServices` into
the ITCases.
+1 from my side
> ZooKeeper based high availability services should not close the underlying
> CuratorFramework
> -------------------------------------------------------------------------------------------
>
> Key: FLINK-6078
> URL: https://issues.apache.org/jira/browse/FLINK-6078
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.3.0
>
>
> ZooKeeper based high availability tools like
> {{ZooKeeperLeaderRetrievalService}} and {{ZooKeeperLeaderElectionService}}
> expect that every instance of the services have a dedicated
> {{CuratorFramework}} instance assigned. Thus, they also close this
> {{CuratorFramework}} when the service is closed. This does not play well
> along with the newly introduced {{HighAvailabilityServices}} which caches a
> single {{CuratorFramework}} and shares it among all created services. In
> order to make it work properly together I propose to change the behaviour
> such that we no longer close the {{CuratorFramework}} clients in the
> ZooKeeper based services.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
