Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114545441
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala
---
@@ -327,4 +332,56 @@ object ProjectionTranslator {
}
}
+ /**
+ * Find and replace UDAGG function Call to UDAGGFunctionCall
+ *
+ * @param field the expression to check
+ * @param tableEnv the TableEnvironment
+ * @return an expression with correct UDAGGFunctionCall type for UDAGG
functions
+ */
+ def replaceUDAGGFunctionCall(field: Expression, tableEnv:
TableEnvironment): Expression = {
--- End diff --
Couldn't we do the replacement during `replaceAggregationsAndProperties`?
Save some duplicate code? Actually, `LogicalNode#resolveExpressions` is
responsible for looking up calls. Maybe this logic has to be adapted a little
bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
