Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114538809
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -691,6 +692,8 @@ trait ImplicitExpressionConversions {
implicit def sqlTimestamp2Literal(sqlTimestamp: Timestamp): Expression =
Literal(sqlTimestamp)
implicit def array2ArrayConstructor(array: Array[_]): Expression =
convertArray(array)
+ implicit def UserDefinedAggFunctionConstructor[T: TypeInformation,
ACC](udagg:
+ AggregateFunction[T, ACC]): UDAGGExpression[T, ACC] =
UDAGGExpression(udagg)
--- End diff --
Do we need this `UDAGGExpression`? Can't we convert directly into
`UDAGGFunctionCall`? Imho I would call this `AggregateFunctionCall` and avoid
acronyms.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
