[ 
https://issues.apache.org/jira/browse/FLINK-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996723#comment-15996723
 ] 

ASF GitHub Bot commented on FLINK-6164:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3824#discussion_r114771179
  
    --- Diff: 
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/function/ProcessAllWindowFunction.scala
 ---
    @@ -35,7 +35,9 @@ import org.apache.flink.util.Collector
       * @tparam W The type of the window.
       */
     @PublicEvolving
    -abstract class ProcessAllWindowFunction[IN, OUT, W <: Window] extends 
Function with Serializable {
    +abstract class ProcessAllWindowFunction[IN, OUT, W <: Window]
    --- End diff --
    
    I think the `Serializable` is not needed here. (Was there before, so not 
introduced in this PR)


> Make ProcessWindowFunction a RichFunction
> -----------------------------------------
>
>                 Key: FLINK-6164
>                 URL: https://issues.apache.org/jira/browse/FLINK-6164
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Aljoscha Krettek
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> {{ProcessWindowFunction}} is an abstract class so we can make it a 
> {{RichFunction}} by default and remove {{RichProcessWindowFunction}}. This is 
> in line with {{ProcessFunction}} which is also a {{RichFunction}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to