[
https://issues.apache.org/jira/browse/FLINK-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996724#comment-15996724
]
ASF GitHub Bot commented on FLINK-6164:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3824#discussion_r114772035
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/AccumulatingAlignedProcessingTimeWindowOperatorTest.java
---
@@ -1038,7 +1038,7 @@ private void assertInvalidParameter(long windowSize,
long windowSlide) {
//
------------------------------------------------------------------------
- private static class StatefulFunction extends
RichProcessWindowFunction<Integer, Integer, Integer, TimeWindow> {
+ private static class StatefulFunction extends
ProcessWindowFunction<Integer, Integer, Integer, TimeWindow> {
--- End diff --
With this we add two unused imports.
And yes, I don't like that we don't have checkstyle active on the tests.
> Make ProcessWindowFunction a RichFunction
> -----------------------------------------
>
> Key: FLINK-6164
> URL: https://issues.apache.org/jira/browse/FLINK-6164
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Aljoscha Krettek
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.3.0
>
>
> {{ProcessWindowFunction}} is an abstract class so we can make it a
> {{RichFunction}} by default and remove {{RichProcessWindowFunction}}. This is
> in line with {{ProcessFunction}} which is also a {{RichFunction}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
