[
https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997619#comment-15997619
]
ASF GitHub Bot commented on FLINK-5884:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114907167
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -60,26 +61,31 @@ object AggregateUtil {
* window to evaluate final aggregate value.
*
* @param generator code generator instance
- * @param namedAggregates List of calls to aggregate functions and
their output field names
- * @param inputType Input row type
+ * @param namedAggregates Physical calls to aggregate functions and
their output field names
+ * @param inputType Physical type of the row.
+ * @param inputTypeInfo Physical type information of the row.
+ * @param inputFieldTypeInfo Physical type information of the row's
fields.
* @param isRowTimeType It is a tag that indicates whether the time
type is rowTimeType
* @param isPartitioned It is a tag that indicate whether the input is
partitioned
* @param isRowsClause It is a tag that indicates whether the OVER
clause is ROWS clause
*/
private[flink] def createUnboundedOverProcessFunction(
- generator: CodeGenerator,
- namedAggregates: Seq[CalcitePair[AggregateCall, String]],
- inputType: RelDataType,
- isRowTimeType: Boolean,
- isPartitioned: Boolean,
- isRowsClause: Boolean): ProcessFunction[Row, Row] = {
+ generator: CodeGenerator,
+ namedAggregates: Seq[CalcitePair[AggregateCall, String]],
+ inputType: RelDataType,
+ inputTypeInfo: TypeInformation[Row],
+ inputFieldTypeInfo: Seq[TypeInformation[_]],
+ isRowTimeType: Boolean,
+ isPartitioned: Boolean,
+ isRowsClause: Boolean)
+ : ProcessFunction[Row, Row] = {
val needRetract = false
--- End diff --
remove or revert the next change
> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
> Key: FLINK-5884
> URL: https://issues.apache.org/jira/browse/FLINK-5884
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators
> (event-time or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we
> can solve this issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
