[
https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997615#comment-15997615
]
ASF GitHub Bot commented on FLINK-5884:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114896129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCorrelate.scala
---
@@ -44,36 +44,34 @@ trait CommonCorrelate {
*/
private[flink] def correlateMapFunction(
config: TableConfig,
- inputTypeInfo: TypeInformation[Row],
+ inputSchema: RowSchema,
udtfTypeInfo: TypeInformation[Any],
- rowType: RelDataType,
+ returnSchema: RowSchema,
joinType: SemiJoinType,
rexCall: RexCall,
condition: Option[RexNode],
pojoFieldMapping: Option[Array[Int]], // udtf return type pojo field
mapping
ruleDescription: String)
: CorrelateFlatMapRunner[Row, Row] = {
- val returnType = FlinkTypeFactory.toInternalRowTypeInfo(rowType)
-
val flatMap = generateFunction(
config,
- inputTypeInfo,
+ inputSchema.physicalTypeInfo,
udtfTypeInfo,
- returnType,
- rowType,
+ returnSchema.physicalTypeInfo,
+ returnSchema.logicalFieldNames,
joinType,
- rexCall,
+ inputSchema.mapRexNode(rexCall).asInstanceOf[RexCall],
pojoFieldMapping,
ruleDescription)
val collector = generateCollector(
config,
- inputTypeInfo,
+ inputSchema.physicalTypeInfo,
udtfTypeInfo,
- returnType,
- rowType,
- condition,
+ returnSchema.physicalTypeInfo,
+ returnSchema.logicalFieldNames,
+ condition.map(inputSchema.mapRexNode),
--- End diff --
Do we need to check that `condition` does not contain a time indicator?
> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
> Key: FLINK-5884
> URL: https://issues.apache.org/jira/browse/FLINK-5884
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators
> (event-time or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we
> can solve this issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
