Github user DmytroShkvyra commented on a diff in the pull request:
https://github.com/apache/flink/pull/3673#discussion_r115685695
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapJoinLeftRunner.scala
---
@@ -31,7 +32,19 @@ class MapJoinLeftRunner[IN1, IN2, OUT](
override def flatMap(multiInput: IN1, out: Collector[OUT]): Unit = {
broadcastSet match {
case Some(singleInput) => function.join(multiInput, singleInput, out)
- case None =>
+ case None => {
--- End diff --
Really, I cant imagine situation when there we will got null. Please see in
/flink/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapSideJoinRunner.scala
who is parent of these runners.
org/apache/flink/table/runtime/MapSideJoinRunner.scala:48
` broadcastSet = retrieveBroadcastSet
}
private def retrieveBroadcastSet: Option[SINGLE_IN] = {
val broadcastSet =
getRuntimeContext.getBroadcastVariable(broadcastSetName)
if (!broadcastSet.isEmpty) {
Option(broadcastSet.get(0))
} else {
Option.empty
}
}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
