Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3673#discussion_r115786774
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/sql/JoinITCase.scala
---
@@ -372,11 +366,219 @@ class JoinITCase(
val sqlQuery1 = "SELECT * FROM A CROSS JOIN (SELECT count(*) FROM A
HAVING count(*) < 0)"
val result = tEnv.sql(sqlQuery1).count()
-
Assert.assertEquals(0, result)
}
@Test
+ def testLeftNullLeftJoin (): Unit = {
--- End diff --
Several of these tests are executed with regular joins because of the
restriction that for an outer single row join, the single row input must be on
the inner side. Some of these tests have the single row input on the outer side
which will translate them into regular joins (which is only possible because
the join conditions are equality predicates). These tests can be removed,
because they test the existing join implementation.
In order to enforce tests of the new outer single row joins, the join
condition must be an inequality predicate. It would be good to adapt the tests
queries accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
