Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3863#discussion_r115734636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupAggregate.scala
---
@@ -100,9 +104,18 @@ class DataStreamGroupAggregate(
inputSchema.logicalType, groupings, getRowType, namedAggregates,
Nil))
}
- override def translateToPlan(tableEnv: StreamTableEnvironment):
DataStream[CRow] = {
+ override def translateToPlan(
+ tableEnv: StreamTableEnvironment,
+ qConfig: StreamQueryConfig): DataStream[CRow] = {
+
+ if (qConfig.getMinIdleStateRetentionTime < 0 ||
qConfig.getMaxIdleStateRetentionTime < 0) {
--- End diff --
we should also check that this is not a global aggregate and only emit a
warning if the aggregate is partitioned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
