Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3863#discussion_r115778815
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/OverWindowHarnessTest.scala
 ---
    @@ -265,7 +123,7 @@ class OverWindowHarnessTest extends HarnessTestBase{
             Row.of(2: JInt, 0L: JLong, 0: JInt, "bbb", 30L: JLong, 20L: JLong, 
30L: JLong), true), 1))
         expectedOutput.add(new StreamRecord(
           CRow(
    -        Row.of(1: JInt, 11L: JLong, 1: JInt, "aaa", 7L: JLong, 6L: JLong, 
7L: JLong), true), 2))
    +        Row.of(1: JInt, 11L: JLong, 1: JInt, "aaa", 7L: JLong, 7L: JLong, 
7L: JLong), true), 2))
    --- End diff --
    
    The state for this record may not have been deleted before. The last input 
for that key is on time `1100` and the min retention time is `2000ms`, so the 
state should be kept at least until `3100` but was already discarded at `3001` 
(this is the bug that I pointed out earlier).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to