Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116212331
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamGroupWindowAggregateRule.scala
---
@@ -44,14 +44,19 @@ class DataStreamGroupWindowAggregateRule
if (distinctAggs) {
throw TableException("DISTINCT aggregates are currently not
supported.")
}
+ // check if we have over aggregates
+ val overAggs =
agg.getAggCallList.exists(_.getAggregation.requiresOver())
+ if (overAggs) {
+ throw TableException("OVER clause is necessary for requires over
window functions")
+ }
// check if we have grouping sets
val groupSets = agg.getGroupSets.size() != 1 ||
agg.getGroupSets.get(0) != agg.getGroupSet
if (groupSets || agg.indicator) {
throw TableException("GROUPING SETS are currently not supported.")
}
- !distinctAggs && !groupSets && !agg.indicator
--- End diff --
This check must not be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
