Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3851#discussion_r116211695
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/DataSetWindowAggregateRule.scala
---
@@ -49,7 +49,13 @@ class DataSetWindowAggregateRule
throw TableException("GROUPING SETS are currently not supported.")
}
- !distinctAggs && !groupSets && !agg.indicator
--- End diff --
This check must not be removed. Instead we should return with `false` from
`matches`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
