[
https://issues.apache.org/jira/browse/FLINK-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008138#comment-16008138
]
ASF GitHub Bot commented on FLINK-6518:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/3865#discussion_r116233068
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
@@ -111,34 +111,32 @@ private BlobServer(Configuration config, BlobStore
blobStore) throws IOException
this.blobStore = checkNotNull(blobStore);
// configure and create the storage directory
- String storageDirectory =
config.getString(ConfigConstants.BLOB_STORAGE_DIRECTORY_KEY, null);
+ String storageDirectory =
config.getString(BlobServerOptions.STORAGE_DIRECTORY);
this.storageDir =
BlobUtils.initStorageDirectory(storageDirectory);
LOG.info("Created BLOB server storage directory {}",
storageDir);
// configure the maximum number of concurrent connections
- final int maxConnections = config.getInteger(
- ConfigConstants.BLOB_FETCH_CONCURRENT_KEY,
ConfigConstants.DEFAULT_BLOB_FETCH_CONCURRENT);
+ final int maxConnections =
config.getInteger(BlobServerOptions.FETCH_CONCURRENT);
if (maxConnections >= 1) {
--- End diff --
I had only meant to suggest this as a follow-up.
> Migrate BlobServer configuration options
> ----------------------------------------
>
> Key: FLINK-6518
> URL: https://issues.apache.org/jira/browse/FLINK-6518
> Project: Flink
> Issue Type: Sub-task
> Components: Local Runtime
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
