Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3851#discussion_r116443377
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/GroupWindowTest.scala
 ---
    @@ -30,6 +30,23 @@ import org.junit.{Ignore, Test}
     
     class GroupWindowTest extends TableTestBase {
     
    +  /**
    +    * OVER clause is necessary for [[OverAgg0]] window function.
    +    */
    +  @Test(expected = classOf[TableException])
    +  def testOverAggregation(): Unit = {
    +    val util = streamTestUtil()
    +    val table = util.addTable[(Long, Int, String)]('long, 'int, 'string, 
'proctime.proctime)
    +
    +    val overAgg = new OverAgg0
    +    val windowedTable = table
    +      .window(Tumble over 2.rows on 'proctime as 'w)
    +      .groupBy('w, 'string)
    +      .select(overAgg('long, 'int))
    +
    +    util.verifyTable(windowedTable, "n/a")
    --- End diff --
    
    When the check is done in validation phase, we do not have to call 
`verifyTable()` (same for all other Table API tests).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to