[
https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011789#comment-16011789
]
ASF GitHub Bot commented on FLINK-6539:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3911#discussion_r116659967
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java
---
@@ -1,75 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.streaming.examples.kafka;
-
-import org.apache.flink.api.common.restartstrategy.RestartStrategies;
-import org.apache.flink.api.java.utils.ParameterTool;
-import org.apache.flink.streaming.api.datastream.DataStream;
-import
org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
-import org.apache.flink.streaming.api.functions.source.SourceFunction;
-import org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer08;
-import org.apache.flink.streaming.util.serialization.SimpleStringSchema;
-
-
-/**
- * Generate a String every 500 ms and write it into a Kafka topic
- *
- * Please pass the following arguments to run the example:
- * --topic test --bootstrap.servers localhost:9092
- *
- */
-public class WriteIntoKafka {
--- End diff --
I understand the intention here, but instead of completely removing this
class, shouldn't we just have a new `Kafka010EndToEndExample` instead of
replacing the separate write / read examples? Perhaps the end-to-end example
should just reuse code from the write / read examples.
> Add automated end-to-end tests
> ------------------------------
>
> Key: FLINK-6539
> URL: https://issues.apache.org/jira/browse/FLINK-6539
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> We should add simple tests that exercise all the paths that a user would use
> when starting a cluster and submitting a program. Preferably with a simple
> batch program and a streaming program that uses Kafka.
> This would have catched some of the bugs that we now discovered right before
> the release.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
