[ 
https://issues.apache.org/jira/browse/FLINK-6539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011792#comment-16011792
 ] 

ASF GitHub Bot commented on FLINK-6539:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3911#discussion_r116659435
  
    --- Diff: .test-infa/end-to-end-test/test_streaming_kafka010.sh ---
    @@ -0,0 +1,102 @@
    +#!/usr/bin/env bash
    
+################################################################################
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +set -e
    +set -o pipefail
    +
    +# Convert relative path to absolute path
    +TEST_ROOT=`pwd`
    +TEST_INFRA_DIR="$0"
    +TEST_INFRA_DIR=`dirname "$TEST_INFRA_DIR"`
    +cd $TEST_INFRA_DIR
    +TEST_INFRA_DIR=`pwd`
    +cd $TEST_ROOT
    +
    +. "$TEST_INFRA_DIR"/common.sh
    +
    +
    +start_cluster
    +
    +# get Kafka 0.10.0
    +mkdir -p $TEST_DATA_DIR
    +curl 
"http://mirror.netcologne.de/apache.org/kafka/0.10.2.0/kafka_2.11-0.10.2.0.tgz"; 
> $TEST_DATA_DIR/kafka.tgz
    +# Use this when debugging locally, to keep from always downloading
    +#cp /Users/aljoscha/Dev/flink/kafka.tgz $TEST_DATA_DIR/kafka.tgz
    --- End diff --
    
    Should we actually have an option / flag .with binary path for this 
(instead of going into the script and modifying this)?


> Add automated end-to-end tests
> ------------------------------
>
>                 Key: FLINK-6539
>                 URL: https://issues.apache.org/jira/browse/FLINK-6539
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>
> We should add simple tests that exercise all the paths that a user would use 
> when starting a cluster and submitting a program. Preferably with a simple 
> batch program and a streaming program that uses Kafka.
> This would have catched some of the bugs that we now discovered right before 
> the release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to