[
https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016114#comment-16016114
]
ASF GitHub Bot commented on FLINK-6603:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3941
[FLINK-6603] [streaming] Enable checkstyle on test sources
Follow-up to FLINK-6107.
The first commit sets the import order as
[discussed](https://issues.apache.org/jira/browse/FLINK-6107?focusedCommentId=15985221&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15985221):
first Flink imports, then other imports, then javax, then java (we could
consider placing javax and java together; I have not looked into the required
regex and we only have a few instances of javax). The groups are separated by a
single newline with static imports moved to the bottom.
The second commit applies the strict checkstyle to the
`flink-streaming-java` tests. The checkstyle line length was increased from
2500 to 3000.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
6603_enable_checkstyle_on_test_sources
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3941
----
commit b71b24f4b3e9a3bb3625e698ea2db18531520379
Author: Greg Hogan <[email protected]>
Date: 2017-05-17T12:01:04Z
Import order
commit 201ab2a6994a9be153cf08a16d3e6f317246dc33
Author: Greg Hogan <[email protected]>
Date: 2017-05-17T16:02:50Z
Fix checkstyle violations
----
> Enable checkstyle on test sources
> ---------------------------------
>
> Key: FLINK-6603
> URL: https://issues.apache.org/jira/browse/FLINK-6603
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Affects Versions: 1.4.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Trivial
> Fix For: 1.4.0
>
>
> With the addition of strict checkstyle to select modules (currently limited
> to {{flink-streaming-java}}) we can enable the checkstyle flag
> {{includeTestSourceDirectory}} to perform the same unused imports,
> whitespace, and other checks on test sources.
> Should first resolve the import grouping as discussed in FLINK-6107. Also,
> several tests exceed the 2500 line limit.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
