[ 
https://issues.apache.org/jira/browse/FLINK-6603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017289#comment-16017289
 ] 

ASF GitHub Bot commented on FLINK-6603:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3941#discussion_r117463525
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
 ---
    @@ -1979,9 +1982,9 @@ public void 
testNotSideOutputDueToLatenessSessionWithHugeLatenessPurgingTrigger(
        }
     
        @Test
    -   public void testNotSideOutputDueToLatenessSessionWithHugeLateness() 
throws Exception {
    -           final int GAP_SIZE = 3;
    -           final long LATENESS = 10000;
    +   public void testNotSideOutputDueTolatenessSessionWithHugelateness() 
throws Exception {
    --- End diff --
    
    .


> Enable checkstyle on test sources
> ---------------------------------
>
>                 Key: FLINK-6603
>                 URL: https://issues.apache.org/jira/browse/FLINK-6603
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.4.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Trivial
>             Fix For: 1.4.0
>
>
> With the addition of strict checkstyle to select modules (currently limited 
> to {{flink-streaming-java}}) we can enable the checkstyle flag 
> {{includeTestSourceDirectory}} to perform the same unused imports, 
> whitespace, and other checks on test sources.
> Should first resolve the import grouping as discussed in FLINK-6107. Also, 
> several tests exceed the 2500 line limit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to