[ 
https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020810#comment-16020810
 ] 

ASF GitHub Bot commented on FLINK-6617:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3943#discussion_r117929380
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TableTestBase.scala
 ---
    @@ -120,7 +125,8 @@ object TableTestUtil {
     }
     
     case class BatchTableTestUtil() extends TableTestUtil {
    -
    +  val javaEnv = mock(classOf[JExecutionEnvironment])
    +  val javaTableEnv = TableEnvironment.getTableEnvironment(javaEnv)
    --- End diff --
    
    Maybe we can rename the Scala environment to `tableEnv` to be consistent.


> Improve JAVA and SCALA logical plans consistent test
> ----------------------------------------------------
>
>                 Key: FLINK-6617
>                 URL: https://issues.apache.org/jira/browse/FLINK-6617
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> Currently,we need some `StringExpression` test,for all JAVA and SCALA API.
> Such as:`GroupAggregations`,`GroupWindowAggregaton`(Session,Tumble),`Calc` 
> etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to