[jira] [Commented] (FLINK-6617) Improve JAVA and SCALA logical plans consistent test

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030934#comment-16030934
 ] 

ASF GitHub Bot commented on FLINK-6617:
---------------------------------------

Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/3943
  
     **I once again seriously consider the Refactoring work, according to the 
following principles updated the PR.**
    
       **First, the test type and purpose(4 types):**
    * Unit Test: to ensure the correctness of the most granular features
    * StringExpression Test: Verify the consistency of java and scalaAPI
    * Validation Test: Check the API exception information
    * Integration Test: Integration testing, verifying runtime and end-to-end 
correctness
    
       **Second, the directory structure(folders) and purpose:**
      
        The TEST directory contains all the paths (folders) of the SRC 
directory - the functional tests included three type test case (**Unit Test**, 
**StringExpression Test**,**Validation Test**)
       **Note:** runtime directory contains both runtime (**Unit Test**, 
**StringExpression Test**,**Validation Test**), and All table API/SQL 
**Integration Test**.
    
       **Third, the file name naming convention:**
    * Unit Test -> functionName + **Test**
    * StringExpression Test -> functionName + **StringExpressionTest**
    * Validation Test -> functionName + **ValidationTest**
    * Integration Test -> FunctionName + **ITCase**
    
    **After the change of the directory structure, as shown below:**
    
    
![image](https://cloud.githubusercontent.com/assets/22488084/26626891/3959615c-462b-11e7-831a-ee3fa8a8ff98.png)
    
    @twalthr @fhueske @wuchong The change is big, so I need your help to ensure 
that the direction of change is correct.
    
    Best,
    SunJincheng


> Improve JAVA and SCALA logical plans consistent test
> ----------------------------------------------------
>
>                 Key: FLINK-6617
>                 URL: https://issues.apache.org/jira/browse/FLINK-6617
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> Currently,we need some `StringExpression` test,for all JAVA and SCALA API.
> Such as:`GroupAggregations`,`GroupWindowAggregaton`(Session,Tumble),`Calc` 
> etc.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)