[
https://issues.apache.org/jira/browse/FLINK-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036427#comment-16036427
]
ASF GitHub Bot commented on FLINK-6817:
---------------------------------------
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4055#discussion_r120023997
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/windows.scala
---
@@ -127,3 +127,21 @@ class PartitionedOver(private val partitionByExpr:
Array[Expression]) {
new OverWindowWithOrderBy(partitionByExpr, orderByExpr)
}
}
+
+
+class OverWindowWithOrderBy(
+ private val partitionByExpr: Array[Expression],
--- End diff --
Suggest that change `partitionByExpr` to `partitionBy` for keep param name
consistent with SCALA. What do you think?
> Fix NPE when preceding is not set in OVER window
> ------------------------------------------------
>
> Key: FLINK-6817
> URL: https://issues.apache.org/jira/browse/FLINK-6817
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Jark Wu
> Priority: Minor
> Fix For: 1.4.0
>
>
> When preceding is not set in over window , a NPE will be thrown:
> {code}
> val result = table
> .window(Over orderBy 'rowtime as 'w)
> .select('c, 'a.count over 'w)
> {code}
> {code}
> java.lang.NullPointerException
> at org.apache.flink.table.api.OverWindowWithOrderBy.as(windows.scala:97)
> {code}
> Preceding must be set in OVER window, so should throw a more explicit
> exception not a NPE
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
