[
https://issues.apache.org/jira/browse/FLINK-6817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045986#comment-16045986
]
ASF GitHub Bot commented on FLINK-6817:
---------------------------------------
GitHub user wuchong opened a pull request:
https://github.com/apache/flink/pull/4104
[FLINK-6817] [table] Add OverWindowWithPreceding class to guide users apply
preceding in over window
This PR is same as #4055 but against to branch 1.3
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wuchong/flink over-1.3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4104
----
commit 867e20b550ad69efa8b4da35d16ae3a4fa3ef92e
Author: Jark Wu <[email protected]>
Date: 2017-06-02T13:28:45Z
[FLINK-6817] [table] Add OverWindowWithPreceding class to guide users apply
preceding in over window
----
> Fix NPE when preceding is not set in OVER window
> ------------------------------------------------
>
> Key: FLINK-6817
> URL: https://issues.apache.org/jira/browse/FLINK-6817
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: Jark Wu
> Assignee: Jark Wu
> Priority: Minor
> Fix For: 1.4.0
>
>
> When preceding is not set in over window , a NPE will be thrown:
> {code}
> val result = table
> .window(Over orderBy 'rowtime as 'w)
> .select('c, 'a.count over 'w)
> {code}
> {code}
> java.lang.NullPointerException
> at org.apache.flink.table.api.OverWindowWithOrderBy.as(windows.scala:97)
> {code}
> Preceding must be set in OVER window, so should throw a more explicit
> exception not a NPE
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
