Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/747#discussion_r31420791
  
    --- Diff: 
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/api/persistent/PersistentKafkaSource.java
 ---
    @@ -256,17 +244,6 @@ private int getNumberOfPartitions() {
                return topic.size();
        }
     
    -   protected void setOffset(int partition, long offset) {
    -           if(commitedOffsets[partition] < offset) {
    -                   setOffset(zkClient, consumerConfig.groupId(), 
topicName, partition, offset);
    -                   commitedOffsets[partition] = offset;
    -           } else {
    -                   LOG.debug("Ignoring offset {} for partition {} because 
it is already committed", offset, partition);
    --- End diff --
    
    So I assume duplicate offset committing is not happening anymore with the 
new interfaces?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to