[
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040762#comment-16040762
]
ASF GitHub Bot commented on FLINK-6859:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4085
[FLINK-6859][table] remove delete useless times for improve StateClea…
- [x] General
- The pull request references the related JIRA issue ([FLINK-6859][table]
remove delete useless times for improve StateCleaningCountTrigger)
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6859-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4085
----
commit 44c3b0de07c16f9d58d21177a06231425bab2add
Author: sunjincheng121 <[email protected]>
Date: 2017-06-07T11:46:32Z
[FLINK-6859][table] remove delete useless times for improve
StateCleaningCountTrigger
----
> StateCleaningCountTrigger should not delete timer
> -------------------------------------------------
>
> Key: FLINK-6859
> URL: https://issues.apache.org/jira/browse/FLINK-6859
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: Fabian Hueske
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or
> not.
> What do you think [~sunjincheng121]?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
