[ 
https://issues.apache.org/jira/browse/FLINK-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042334#comment-16042334
 ] 

ASF GitHub Bot commented on FLINK-6859:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4085


> StateCleaningCountTrigger should not delete timer
> -------------------------------------------------
>
>                 Key: FLINK-6859
>                 URL: https://issues.apache.org/jira/browse/FLINK-6859
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: Fabian Hueske
>            Assignee: sunjincheng
>
> The {{StateCleaningCountTrigger}} which is used to clean-up inactive state 
> should not delete timers, i.e.. not call {{deleteProcessingTimeTimer()}}.
> This is an expensive operation.
> We should rather fire the timer and check if we need to clean the state or 
> not.
> What do you think [~sunjincheng121]?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to