Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/742#issuecomment-107811407
I will fix the remaining cancel() races. The twitter stuff I just commented
out because I assumed that the new TwitterSource could be merged right away and
I was waiting for that.
As for two Source interfaces. We can certainly do that. The reason I didn't
do it is because there would be a lot of duplication because we have
SourceFunction, ParallelSourceFunction, RichSourceFunction and
ParallelRichSourceFunction. With the new Source interface this would go up to 8
interfaces for the sources. (That's also the reason why I didn't have Kafka
derived from the RichParallelSourceFunction, I thought that maybe we could get
rid of the special interfaces for parallel sources.)
Also, I realize there are many more problems. I just can't address them all
in a single PR. :sweat_smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
