Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/742#issuecomment-108615858
I thought about what @StephanEwen said about uncheckpointed sources also
having the locking object in the signature of the run() method and also about
extensibility.
We might have to tweak the source interface a little bit more. What I
propose is to have this run method:
```
void run(SourceContext context);
```
Then the source context would have methods to retrieve the locking object
(for checkpointed sources) and for emitting elements. Part of my motivation for
this is that this can be extended in the future without breaking existing
sources. If we introduce proper timestamps at some point we can extend the
SourceContext with a method for emitting elements with a timestamp. Then, if we
want to have watermarks the context can have methods for activating
automatically generated watermarks and for emitting watermarks. And so on...
I think we should fix this now, before the release. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
