Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4125#discussion_r122869047
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java
---
@@ -225,7 +225,16 @@ private void assignAttemptState(ExecutionJobVertex
executionJobVertex, List<Oper
public void checkParallelismPreconditions(List<OperatorState>
operatorStates, ExecutionJobVertex executionJobVertex) {
-
+ //----------------------------------------parallelism compare
preconditions-------------------------------------
+
+ // if the max parallelism is lower than parallelism, we will
throw an exception.
+ if (executionJobVertex.getMaxParallelism() <
executionJobVertex.getParallelism()) {
--- End diff --
Yes. You are very correct. I will move this check condition into this
method ```checkParallelismCondition(OperatorState, ExecutionJobVertex).``` It
is not probably easier, it is absolutely easier. :1st_place_medal: Lol.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
